Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT B-21114 Address related language changes (Office) #14122

Merged
merged 35 commits into from
Nov 21, 2024

Conversation

brooklyn-welsh
Copy link
Contributor

@brooklyn-welsh brooklyn-welsh commented Nov 6, 2024

Agility ticket

Summary

The following changes were made on the Office/Prime side in order to make address related language consistent across the MilMove app:

  1. "Destination Address" -> "Delivery Address"
  2. "Pickup Location" -> "Pickup Address"
  3. "Current Address" -> "Pickup Address"
  4. "Origin Address" -> "Pickup Address"

How to test

  1. Login as an office user.
  2. Access the move detail page of a move, check that the changes above have applied to the shipment cards.
  3. Edit a shipment, check for changes.
  4. Create a shipment, check for changes.
  5. Login as Prime Sim and do the same for all shipment related controls/pages.

Screenshots

@brooklyn-welsh brooklyn-welsh added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Nov 6, 2024
@robot-mymove
Copy link

robot-mymove commented Nov 6, 2024

Warnings
⚠️

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?

View the frontend file org ADR for more information

Generated by 🚫 dangerJS against 266a495

@brooklyn-welsh brooklyn-welsh marked this pull request as ready for review November 18, 2024 16:04
@brooklyn-welsh brooklyn-welsh requested review from KonstanceH, taeJungCaci and JamesHawks224 and removed request for KonstanceH November 18, 2024 16:04
Copy link
Contributor

@JamesHawks224 JamesHawks224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing: success
code: lgtm

Copy link
Contributor

@taeJungCaci taeJungCaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brooklyn-welsh brooklyn-welsh merged commit 3b5b242 into integrationTesting Nov 21, 2024
30 checks passed
@brooklyn-welsh brooklyn-welsh deleted the INT-B-21114-Office-Address-Language branch November 21, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

4 participants