Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAIN B-20928 #14043

Merged
merged 15 commits into from
Nov 8, 2024
Merged

MAIN B-20928 #14043

merged 15 commits into from
Nov 8, 2024

Conversation

danieljordan-caci
Copy link
Contributor

@danieljordan-caci danieljordan-caci commented Oct 29, 2024

INT PR

Agility ticket

Summary

Security wanted us to not use MD5 hashing, so transitioning to SHA256 for uploads and adding in the CheckSumAlgorithem when uploading to S3.

This also contains code to fix some flaky tests. Idk, man.

How to test

  1. You'll need to go to your .envrc and uncomment export STORAGE_BACKEND=s3
  2. Run direnv allow
  3. Run aws-vault exec transcom-gov-dev -- make server_run
  4. While that's building, make sure you are in the right AWS profile - transcom-gov-dev
  5. This allows us to upload files to S3 instead of locally (docs here)
  6. Log in as a customer, fill out all information and upload some orders
  7. In your CLI, run aws-vault login transcom-gov-dev - this will open the AWS Console
  8. Search for S3 and get in there
  9. Find your buckets
  10. There should be one that says transcom-gov-dev-app-devlocal-us-gov-west-1, click it
  11. You should see your name/repo if the file uploaded correctly (ex. daniel.jordan_cn)
  12. Click through and click the file you uploaded to where you see the Object Overview section
  13. Scroll down and you should see an Additional checksums section
  14. Confirm you see an additional SHA-256 checksum

Screenshots

Screenshot 2024-10-29 at 11 15 28 AM

@danieljordan-caci danieljordan-caci added Mountain Movers Movin' Mountains 1 Sprint at a time MAIN labels Oct 29, 2024
@danieljordan-caci danieljordan-caci self-assigned this Oct 29, 2024
@danieljordan-caci danieljordan-caci marked this pull request as ready for review November 7, 2024 19:58
@danieljordan-caci danieljordan-caci requested a review from a team as a code owner November 7, 2024 19:58
Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a diff in pkg/handlers/internalapi/uploads_test.go, think it went into int with 6c2c731

image

@danieljordan-caci
Copy link
Contributor Author

Seeing a diff in pkg/handlers/internalapi/uploads_test.go, think it went into int with 6c2c731

image

Yup. Correct. That was in INT but not in MAIN when I merged it. Updated it just now!

Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches up!

@deandreJones deandreJones merged commit 6bd3f0d into main Nov 8, 2024
41 checks passed
@deandreJones deandreJones deleted the MAIN-B-20928 branch November 8, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAIN Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

4 participants