-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAIN B-20928 #14043
MAIN B-20928 #14043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing a diff in pkg/handlers/internalapi/uploads_test.go, think it went into int with 6c2c731
Yup. Correct. That was in INT but not in MAIN when I merged it. Updated it just now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches up!
INT PR
Agility ticket
Summary
Security wanted us to not use
MD5
hashing, so transitioning toSHA256
for uploads and adding in theCheckSumAlgorithem
when uploading to S3.This also contains code to fix some flaky tests. Idk, man.
How to test
.envrc
and uncommentexport STORAGE_BACKEND=s3
direnv allow
aws-vault exec transcom-gov-dev -- make server_run
transcom-gov-dev
aws-vault login transcom-gov-dev
- this will open the AWS Consoletranscom-gov-dev-app-devlocal-us-gov-west-1
, click itdaniel.jordan_cn
)Object Overview
sectionAdditional checksums
sectionSHA-256
checksumScreenshots