-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
work on APCalign vignettes/articles & function descriptions #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ehwenk
commented
Jan 23, 2024
- add vignette with more details about each function, including some example code
- ensure 1-sentence function names are similar to longer descriptions
- ensure longer function descriptions identical in manuscript, in function_notes file, and in individual R files for functions
- more work formatting tables for vignettes
- add missing info into vignettes; delete an unused vignette
I'd removed "cf" as a filled word, but Anna pointed out to me this should be treated like "aff". I've adjusted the manuscript as well.
fix documention
* ensure 1-sentence function names are similar to longer descriptions * change new function descriptions file from qmd to rmd * more work formatting tables for vignettes * add missing info into vignettes; delete an unused vignette
dfalster
previously approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
- fix special characters - move file to different folder (following example of other data files used in vignettes)
dfalster
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.