Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add datetime picker #446

Merged
merged 6 commits into from
Aug 9, 2024

Conversation

mdeliatf
Copy link
Contributor

@mdeliatf mdeliatf commented Aug 8, 2024

Description

Add a datetime picker based on react-datepicker.

Preview

Light mode

Screenshot 2024-08-08 alle 15 42 27

Dark mode

Screenshot 2024-08-08 alle 15 42 33

Dependency changes

Dependency Version State
react-datepicker ^7.3.0 Added

Breaking changes

None.

How to test?

nvm use
yarn
yarn storybook

Good PR checkboxes

  • Change has been tested
  • Added/Updated tests
  • Added/Updated stories
  • PR follows conventions
  • Labels are set
  • Project is linked

Good Review checkboxes

ℹ️ Copy the snippet and paste in the review field to fill it
- [ ] I've tested the changes
- [ ] I've agreed on the unit tests (soon to come)
- [ ] I've checked the stories
- [ ] I've read the code and understood it
- [ ] I don't have any more questions
- [ ] I've described any optional improvements
- [ ] I checked PR follows [conventions](https://github.com/traefik/faency#how-to-contribute)

@mdeliatf mdeliatf added enhancement New feature or request status/2-needs-review labels Aug 8, 2024
@mdeliatf mdeliatf requested a review from gndz07 August 8, 2024 13:45
@mdeliatf mdeliatf self-assigned this Aug 8, 2024
Copy link
Member

@gndz07 gndz07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 44c9b5c into traefik:master Aug 9, 2024
2 checks passed
@traefiker
Copy link
Contributor

🎉 This PR is included in version 10.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants