Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ESLint 9 and some plugins #438

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

mdeliatf
Copy link
Contributor

@mdeliatf mdeliatf commented Jul 16, 2024

Description

Add ESLint 9 and the following plugins:

  • eslint-plugin-jsx-a11y
  • eslint-plugin-prettier
  • eslint-plugin-react
  • eslint-plugin-react-hooks
  • eslint-plugin-simple-import-sort

Fix #275

Preview

No visual changes.

Dependency changes

Dependency Version State
@eslint/compat ^1.1.1 Added
@eslint/js ^9.7.0 Added
eslint 9.x Added
eslint-config-prettier ^9.1.0 Added
eslint-plugin-jsx-a11y ^6.9.0 Added
eslint-plugin-prettier ^5.1.3 Added
eslint-plugin-react ^7.34.4 Added
eslint-plugin-react-hooks ^4.6.2 Added
eslint-plugin-simple-import-sort ^12.1.1 Added
globals ^15.8.0 Added
typescript-eslint ^7.16. Added

Breaking changes

None.

Good PR checkboxes

  • Change has been tested
  • Added/Updated tests
  • Added/Updated stories
  • PR follows conventions
  • Labels are set
  • Project is linked

Good Review checkboxes

ℹ️ Copy the snippet and paste in the review field to fill it
- [ ] I've tested the changes
- [ ] I've agreed on the unit tests (soon to come)
- [ ] I've checked the stories
- [ ] I've read the code and understood it
- [ ] I don't have any more questions
- [ ] I've described any optional improvements
- [ ] I checked PR follows [conventions](https://github.com/traefik/faency#how-to-contribute)

@mdeliatf mdeliatf requested a review from gndz07 July 16, 2024 13:03
@mdeliatf mdeliatf self-assigned this Jul 16, 2024
@mdeliatf mdeliatf force-pushed the chore/integrate-eslint-rules branch from 35265d4 to 9944722 Compare July 16, 2024 14:34
Copy link
Member

@gndz07 gndz07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 4a6d617 into traefik:master Jul 16, 2024
4 checks passed
@traefiker
Copy link
Contributor

🎉 This PR is included in version 10.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate eslint rules on Faency
3 participants