Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for both pa.types.is_list and pa.types.is_large_list in assertions #88

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

chasezheng
Copy link
Contributor

No description provided.

@0x26res 0x26res changed the title Check for both pa.types.is_list and pa.types.is_large_list in assertions Add check for both pa.types.is_list and pa.types.is_large_list in assertions Dec 27, 2024
@0x26res
Copy link
Collaborator

0x26res commented Dec 27, 2024

@chasezheng there was a problem with master, the linter wasn't working. I've fixed it. Can you update your branch to use the latest master and the CI should pass.

@chasezheng
Copy link
Contributor Author

I rebased my branch to the latest commit on master.

@0x26res 0x26res self-requested a review December 29, 2024 16:27
@0x26res
Copy link
Collaborator

0x26res commented Dec 29, 2024

@chasezheng one more thing, it looks like your code isn't ruff / black compliant and fails the pre-commit checks.

Can you run the pre-commit hook locally and commit/push the changes:

pip install pre-commit
pre-commit install
pre-commit run --all-files

@0x26res
Copy link
Collaborator

0x26res commented Jan 6, 2025

@chasezheng can you run the linter on your branch? I'd like to merge this and release a new version. Thanks.

@chasezheng
Copy link
Contributor Author

Sorry for the delay. I ran the command as you suggested, and the files are reformatted now.

@0x26res 0x26res merged commit ffc452e into tradewelltech:master Jan 14, 2025
5 checks passed
@0x26res
Copy link
Collaborator

0x26res commented Jan 14, 2025

Thanks for this, I'll try to publish the new version today. Out of curiosity did you get this issue because you use polars?

@chasezheng
Copy link
Contributor Author

I have been using duckdb to query parquet files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants