Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metric delete table status change #878

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Conversation

mooneylert
Copy link
Contributor

Which issue does this PR close?

Closes #
The log monitoring file fails to be deleted #877

Rationale for this change

Metric soft deletion puts pressure on the database

What changes are included in this PR?

Metric soft delete changed to hard delete

Are there any user-facing changes?

None

How does this change test

unit test case

@mooneylert mooneylert changed the title metric delete table status change fix: metric delete table status change Aug 13, 2024
@mooneylert mooneylert marked this pull request as draft August 14, 2024 02:51
@mooneylert mooneylert marked this pull request as ready for review August 14, 2024 02:52
Copy link
Collaborator

@masaimu masaimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masaimu masaimu merged commit 3ddb8d6 into traas-stack:main Aug 14, 2024
5 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants