Bump vue-tsc from 0.39.5 to 1.6.4 #3927

dependabot · 2023-05-04T06:59:52Z

Bumps vue-tsc from 0.39.5 to 1.6.4.

Changelog

1.6.4 (2023/5/4)

feat: support color pickers for inline css

feat: support lang="vue" (#3105) - thanks @HunYan-io

fix: when the source type of v-for is any, the item type should be any (#3108) (#3112)

fix: avoid slots report error when noPropertyAccessFromIndexSignature enabled (#3106)

fix(component-type-helpers): import module causes tsc error (#3114)

fix: empty slot name auto-complete not working

fix: accessing an unknown slot name does not report an error

fix: format adds spaces to v-for if nested template element assigns type to slot props (#2750) (#2757)

fix: parentheses auto insert not working in template

Breaking changes

drop support for Vue 3.3 slots short definition (#3116)

... (truncated)

Commits

c3d0c6a v1.6.4
e165518 v1.6.3
927d564 v1.6.2
93408e3 v1.6.1
34b578e v1.6.0
efa9b71 v1.5.4
245e2a4 v1.5.3
4a3460c v1.5.2
e4f83fc v1.5.1
4e2ea5b v1.5.0
Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [vue-tsc](https://github.com/vuejs/language-tools/tree/HEAD/packages/vue-tsc) from 0.39.5 to 1.6.4. - [Release notes](https://github.com/vuejs/language-tools/releases) - [Changelog](https://github.com/vuejs/language-tools/blob/master/CHANGELOG.md) - [Commits](https://github.com/vuejs/language-tools/commits/v1.6.4/packages/vue-tsc) --- updated-dependencies: - dependency-name: vue-tsc dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

codecov · 2023-05-04T07:04:44Z

Codecov Report

Patch and project coverage have no change.

Comparison is base (c7d4244) 86.34% compared to head (cbabbd4) 86.34%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3927   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files          66       66           
  Lines        4709     4709           
  Branches      563      563           
=======================================
  Hits         4066     4066           
  Misses        637      637           
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

This reverts commit 843225e.

This reverts commit 3b13b10.

dependabot · 2023-05-15T07:12:57Z

A newer version of vue-tsc exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

ras0q · 2023-06-04T14:20:00Z

src/components/Main/MainView/PrimaryViewSidebar/SidebarEvent/SidebarEvent.vue

@@ -50,4 +44,12 @@ const comp = computed(() => {
  console.error('Unexpected event:', invalid)
  return undefined
 })
+
+const event = computed(() => {


FIXME: ここをeventAttrsなど別の名前にすると落ちる

見てみたんですけど、v-bind使ったときに型がバグってるか複雑なことしないといけなさそうな気がするので、諦めて↓のようにするかeventのままにしておくのがいい気がします...

いい感じに場合分けするのを諦める場合↓

<sidebar-event-topic-changed v-if="event.type === ChannelEventTypeEnum.TopicChanged" :datetime="event.datetime" :details="event.detail" /> <sidebar-event-subscribers-changed v-else-if="event.type === ChannelEventTypeEnum.SubscribersChanged" :datetime="event.datetime" :details="event.detail" /> <sidebar-event-pinned-changed v-else-if=" event.type === ChannelEventTypeEnum.PinAdded || event.type === ChannelEventTypeEnum.PinRemoved " :datetime="event.datetime" :details="event.detail" :type="event.type" /> <sidebar-event-name-changed v-else-if="event.type === ChannelEventTypeEnum.NameChanged" :datetime="event.datetime" :details="event.detail" /> <sidebar-event-parent-changed v-else-if="event.type === ChannelEventTypeEnum.ParentChanged" :datetime="event.datetime" :details="event.detail" /> <sidebar-event-archive-changed v-else-if="event.type === ChannelEventTypeEnum.VisibilityChanged" :datetime="event.datetime" :details="event.detail" /> <sidebar-event-forced-notification-changed v-else-if="event.type === ChannelEventTypeEnum.ForcedNotificationChanged" :datetime="event.datetime" :details="event.detail" /> <sidebar-event-child-created v-else-if="event.type === ChannelEventTypeEnum.ChildCreated" :datetime="event.datetime" :details="event.detail" />

PinChangedをPinAddedとPinRemovedに分けてtypeに依存しないようにしたら行けると思うんですがそれだとどうですか？

やってみたら無理だったので諦めます

ras0q · 2023-06-04T14:21:45Z

src/components/Modal/ModalContainer.vue

-// ここでpathを束縛することでcomputed内で戻り値の関数がpathに依存していることが伝わる？
-const getComponent = (path: string) =>
-  defineAsyncComponent(() =>
-    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-    modalModules[`/src/components/Modal/${path}.vue`]!()
-  )
-
-const component = computed(() =>
-  currentState.value
-    ? getComponent(modalComponentMap[currentState.value.type])
-    : undefined
-)
+const component = computed(() => {
+  switch (currentState.value?.type) {
+    case 'user':
+      return UserModal
+    case 'notification':
+      return NotificationModal
+    case 'tag':
+      return TagModal
+    case 'group':
+      return GroupModal
+    case 'channel-create':
+      return ChannelCreateModal
+    case 'file':
+      return FileModal
+    case 'qrcode':
+      return QRCodeModal
+    case 'clip-create':
+      return ClipCreateModal
+    case 'clip-folder-create':
+      return ClipFolderCreateModal
+    case 'channel-manage':
+      return ChannelManageModal
+    case 'group-create':
+      return GroupCreateModal
+    case 'group-member-edit':
+      return GroupMemberEditModal
+    case 'group-admin-add':
+      return GroupAdminAddModal
+    case 'group-member-add':
+      return GroupMemberAddModal
+  }
+  // eslint-disable-next-line no-console
+  console.error('Unexpected modal type:', currentState.value)
+  return undefined
+})


型を参照するために静的にimportしたけどパフォーマンス悪くなる？(未検証)

手元でビルドすると感じなかった

ras0q · 2023-07-10T02:10:29Z

@mehm8128 諦めの修正しました

mehm8128

ありがとうございます
動いてるので多分よさそうです

nokhnaton

よさそうです

dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 4, 2023

dependabot bot mentioned this pull request May 4, 2023

Bump vue-tsc from 0.39.5 to 1.6.3 #3925

Closed

ras0q self-assigned this May 7, 2023

ras0q added 6 commits May 8, 2023 09:23

🎨 nest inline-markdown in styled span

3b13b10

🎨 nest router-link in span

843225e

Revert ":art: nest router-link in span"

d6d2b10

This reverts commit 843225e.

Revert ":art: nest inline-markdown in styled span"

86ff8d7

This reverts commit 3b13b10.

🔧 detect data-* and aria-*

79e6007

🎨 resolve dynamic component type

e636fb9

ras0q added 2 commits June 4, 2023 19:19

Merge branch 'master' into dependabot/npm_and_yarn/vue-tsc-1.6.4

ed6fc84

🩹 specify dynamic component's attributes

cbabbd4

ras0q reviewed Jun 4, 2023

View reviewed changes

ras0q requested review from zer0-star, sapphi-red, mehm8128 and nokhnaton June 6, 2023 10:49

ras0q mentioned this pull request Jun 10, 2023

upgrade typescript to 5.0.4, vue to 3.3.4, pinia to 2.1.3, @pinia/testing to 0.1.2 #3990

Merged

♻️ quit using dynamic component

e7ce30d

mehm8128 approved these changes Jul 11, 2023

View reviewed changes

nokhnaton approved these changes Jul 11, 2023

View reviewed changes

ras0q merged commit 5f8edcf into master Jul 11, 2023

ras0q deleted the dependabot/npm_and_yarn/vue-tsc-1.6.4 branch July 11, 2023 12:57

mehm8128 linked an issue Jul 13, 2023 that may be closed by this pull request

vueのコンポーネントにaria属性を付けられない問題 #3849

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump vue-tsc from 0.39.5 to 1.6.4 #3927

Bump vue-tsc from 0.39.5 to 1.6.4 #3927

dependabot bot commented on behalf of github May 4, 2023 •

edited

Loading

codecov bot commented May 4, 2023 •

edited

Loading

dependabot bot commented on behalf of github May 15, 2023

ras0q Jun 4, 2023

mehm8128 Jul 3, 2023

ras0q Jul 10, 2023 •

edited

Loading

ras0q Jun 4, 2023

ras0q Jul 10, 2023

ras0q commented Jul 10, 2023

mehm8128 left a comment

nokhnaton left a comment

Bump vue-tsc from 0.39.5 to 1.6.4 #3927

Bump vue-tsc from 0.39.5 to 1.6.4 #3927

Conversation

dependabot bot commented on behalf of github May 4, 2023 • edited Loading

1.6.4 (2023/5/4)

codecov bot commented May 4, 2023 • edited Loading

Codecov Report

dependabot bot commented on behalf of github May 15, 2023

ras0q Jun 4, 2023

Choose a reason for hiding this comment

mehm8128 Jul 3, 2023

Choose a reason for hiding this comment

ras0q Jul 10, 2023 • edited Loading

Choose a reason for hiding this comment

ras0q Jun 4, 2023

Choose a reason for hiding this comment

ras0q Jul 10, 2023

Choose a reason for hiding this comment

ras0q commented Jul 10, 2023

mehm8128 left a comment

Choose a reason for hiding this comment

nokhnaton left a comment

Choose a reason for hiding this comment

dependabot bot commented on behalf of github May 4, 2023 •

edited

Loading

codecov bot commented May 4, 2023 •

edited

Loading

ras0q Jul 10, 2023 •

edited

Loading