-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[137] GA API V4 #141
base: master
Are you sure you want to change the base?
[137] GA API V4 #141
Conversation
@tpitale this is a great library. Thank you for your work on it. It looks like a pretty good effort to get GA4 going and that effort is one that's becoming pretty urgent with GA4 on the horizon. It's not clear to me if the todo list on this PR is accurate based on the amount of code I see. Do you have a clear sense of what work is left? Do you think Legato will end up supporting GA4 soonish? Is there something a fairly senior Ruby dev, or the community as a whole could do to help get this done? |
The library does not support all the functions of the previous version so far. That's what all the TODOs are for. It should be ready for someone with a V4 capable account to test some basic metrics/dimensions queries. If the basics work, I'm happy to merge this and start more focused work on the other features. I hope it will support V4, but I'm not working at a company which uses GA (and haven't for years). I'm also open to anyone taking this branch and trying to get more features added. |
Nope … I'm conflating this with V4 work on Staccato. I haven't looked at this in a long time. It's a shame, but I'm just not doing ruby much either. I've got a young kid and very little free time. It happens. |
Don't give up. I'm actually in a meeting about Staccato/Legato. We use it as part of Hyrax for an academic archive, so I'm not sure how we could help with testing more than page views, but we can try. Is the readme on this branch updated for G4? |
@tpitale I think there is a good chance that the Hyrax community (which uses this gem and has a lot of energy about getting a G4 update done) can take this branch and move it forward as long as you are ok with that / would be willing to potentially merge / release. I 100% understand the young kid thing and moving on professionally. Are you open to the idea of additional maintainers? also, thank you for replying so quickly =-) I know that even that can be hard to make time for sometimes |
Thanks everyone. I'm happy to take on more maintainers. If you wouldn't mind, let me try to take a run at it again this weekend. Catch up again on Monday? |
Looking over this again, I have a local version of the branch where I've made progress handling the response. I think I just need to map the dimension/metrics to the rows (https://developers.google.com/analytics/devguides/reporting/core/v4/migration#rows) and then very basic testing can begin. After that, I think the only other part that NEEDS to happen is handling the filtering, which I think is a critical part of functionality. Maybe I'm wrong about that? |
filtering is pretty critical for the Hyrax use case. |
If it helps in anything... I did a small api wrapper that includes filtering too: |
resolves #137