refactor(dht): introduce a single DHT server state #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1480134706
💛 - Coveralls |
kpp
reviewed
Nov 13, 2021
| @@ -233,12 +251,22 @@ impl Server { | |||
|
|
|||
| /// Check if we have at least one node in good state. | |||
| pub async fn is_connected(&self) -> bool { | |||
| self.close_nodes.read() | |||
| self.state.read() | |||
There was a problem hiding this comment.
let state = self.state.read().await;
This should fix a deadlock we currently have on master. Later we can move more stuff in this state and make it pure version of DHT server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a deadlock we currently have on master. Later we can
move more stuff in this state and make it pure version of DHT server.