Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nom): update to the latest version #459

Merged
merged 1 commit into from
Nov 12, 2021
Merged

refactor(nom): update to the latest version #459

merged 1 commit into from
Nov 12, 2021

Conversation

kurnevsky
Copy link
Member

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1405233977

  • 783 of 836 (93.66%) changed or added relevant lines in 87 files are covered.
  • 52 unchanged lines in 21 files lost coverage.
  • Overall coverage increased (+0.04%) to 85.565%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tox_packet/src/dht/dht_request.rs 43 44 97.73%
tox_packet/src/dht/mod.rs 1 2 50.0%
tox_packet/src/friend_connection/mod.rs 1 2 50.0%
tox_packet/src/messenger/mod.rs 1 2 50.0%
tox_packet/src/messenger/typing.rs 9 10 90.0%
tox_packet/src/onion/inner_onion_request.rs 1 2 50.0%
tox_packet/src/onion/inner_onion_response.rs 1 2 50.0%
tox_packet/src/onion/onion_data_response.rs 12 13 92.31%
tox_packet/src/relay/data.rs 5 6 83.33%
tox_packet/src/relay/mod.rs 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
tox_core/src/onion/client/paths_pool.rs 1 85.45%
tox_packet/src/dht/dht_request.rs 1 95.04%
tox_packet/src/messenger/conference/title.rs 1 87.5%
tox_packet/src/messenger/msi.rs 1 77.0%
tox_packet/src/relay/onion_request.rs 1 77.78%
tox_packet/src/messenger/conference/invite.rs 2 73.68%
tox_packet/src/messenger/conference/peer_online.rs 2 76.47%
tox_packet/src/messenger/conference/query_response.rs 2 90.77%
tox_packet/src/onion/onion_announce_response.rs 2 95.1%
tox_core/src/state_format/old.rs 3 82.58%
Totals Coverage Status
Change from base Build 1405230274: 0.04%
Covered Lines: 14819
Relevant Lines: 17319

💛 - Coveralls

@kurnevsky kurnevsky merged commit c7e7813 into master Nov 12, 2021
@kurnevsky kurnevsky deleted the nom branch November 12, 2021 20:50
@kpp
Copy link
Member

kpp commented Nov 13, 2021

That's a huge amout of work. Did it affect the binary size? I expect it to shrink a little bit.

@kurnevsky
Copy link
Member Author

I didn't check, but it shouldn't affect it much. Ahync/await should be the biggest part of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants