Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label info from #555 to contributor docs. #780

Closed
wants to merge 1 commit into from
Closed

Add label info from #555 to contributor docs. #780

wants to merge 1 commit into from

Conversation

obestwalter
Copy link
Member

Salvaged the explanation of label meanings and added it to the contributor docs. I think a lot of that should actually live in the actual docs, but for that I opened #779.

@codecov
Copy link

codecov bot commented Mar 24, 2018

Codecov Report

Merging #780 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #780   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files          11       11           
  Lines        2408     2408           
=======================================
  Hits         2284     2284           
  Misses        124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d799a45...1b177c2. Read the comment docs.

@The-Compiler
Copy link
Member

Now that GitHub supports label descriptions, why not put them there (where people would probably expect them) instead of a document separate from the labels?

@obestwalter
Copy link
Member Author

obestwalter commented Mar 24, 2018

Hey @The-Compiler - thanks! Didn't know about that - will do :)

Closing this then.

@nicoddemus
Copy link
Member

nicoddemus commented Mar 24, 2018 via email

@obestwalter obestwalter deleted the issue-labels-doc branch April 13, 2018 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants