New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #426 by writing directly to stdout buffer if possible to prevent str vs bytes issues. #739

Merged

gaborbernat merged 2 commits into tox-dev:master from fschulze:426-typeerror-on-write

Jan 11, 2018

fschulze commented Jan 11, 2018 •

edited

Loading

wrote descriptive pull request text
added/updated test(s) (no idea how to write a test for this)
updated/extended the documentation (not applicable)
added relevant issue keyword
in message body
added news fragment in changelog folder
- fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
- <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
- if pr has no issue: consider creating one first or change it to the pr number after creating the pr
- "sign" fragment with "by @"
- please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by @superuser."
- also see examples
added yourself to CONTRIBUTORS (preserving alphabetical order)

fschulze added 2 commits

January 11, 2018 13:43


          Fix tox-dev#426 by writing directly to stdout buffer if possible to p…

fcd44e3

…revent str vs bytes issues.


          Don't use assert in production code.

848d0c8

fschulze force-pushed the 426-typeerror-on-write branch from 556e2d6 to 848d0c8 Compare

January 11, 2018 12:43

fschulze mentioned this pull request

TypeError: write() argument must be str, not bytes #426

Closed

gaborbernat approved these changes

View reviewed changes

gaborbernat merged commit 51ea308 into tox-dev:master

Contributor

asottile commented Jan 11, 2018

Wow, can't believe I wasn't already in the list lol (given I'm currently #4). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet