Don't attempt to parse dicts if not replacing #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading in the config and processing dict content we were splitting on = assuming we would always have key = value pairs. However in the case where we don't want to replace because the testenv will not be used this can result in ValueErrors as substitution variables are not string key = value pairs. Avoid all this by only attempting to process dict key = values if we are replacing in the first place. Otherwise the content isn't needed and we just return the default value or empty dict. This should fix tox-dev#595
We also need to avoid trying to parse bool types when not replacing as they may be unsubstituted variables that are not a valid bool type. Just don't check them if we are not replacing and use the default value instead.
|
Great, thank you! I will fix up whatever is missing and push a bug fix release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading in the config and processing dict content we were splitting
on = assuming we would always have key = value pairs. However in the
case where we don't want to replace because the testenv will not be used
this can result in ValueErrors as substitution variables are not string
key = value pairs.
Avoid all this by only attempting to process dict key = values if we are
replacing in the first place. Otherwise the content isn't needed and we
just return the default value or empty dict.
This should fix #595
Thanks for contributing a PR!
Here's a quick checklist of what we'd like you to think off:
CONTRIBUTORS;