-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display a short documentation with the -l/ show envlist (a concatenation of the environments description) #489
Conversation
tox/session.py
Outdated
for env in self.config.envlist: | ||
self.report.line("%s" % env) | ||
self.report.line("{} {}".format(env.ljust(max_length), self.config.envconfigs[env].description)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be {0} {1}
to work on Python 2.6 - it seems like it doesn't get caught in the tests though, and they report "can not run tests involving calling tox on python2.6. (and python2.6 is about to be deprecated anyway)"...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@The-Compiler indeed, fixed that, thanks!
@The-Compiler , @obestwalter now that the CI checks passed, can you guys take a look? thanks! |
LGTM (though I don't know tox' code very well), but I'll let @obestwalter press the button 😉 |
LGTM as well, but I feel we should add docs about this new feature first. |
@@ -1,3 +1,4 @@ | |||
.vagrant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha - nice to see it's being used already - does not really belong to this PR, but won't hurt anyone to just add it now, I guess :)
@The-Compiler what an honour :D - I agree with @nicoddemus that this deserves some documentation (somewhere here-ish) before we call this done. |
@obestwalter hmm, I thought that's automatically taken during documentation generation from here:
Where is that shown otherwise? |
When doing |
@obestwalter , @The-Compiler done 👍 |
Played around with it locally a bit and it looks good. Looking forward to the next step that fixes #271. |
I can't get this to work with the 2.7.0 preview with this tox.ini. Both |
o.k. just tried the unconditional approach with 2.7.0 from devpi with this ini:
So from how I understand it, it works like it should. Am I missing something? |
Oh, damn, my bad! I was running my systemwide tox instead of the one from the virtualenv... nevermind! 😊 |
@obestwalter cool, submitted the PR for #271 in #495 |
This is the implementation for #462.
For example: