Revert "Warn about commands key missing in tox.ini" #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obestwalter
requested changes
Feb 17, 2017
CHANGELOG
Outdated
| @@ -59,9 +59,6 @@ | |||
| - fix #399. Make sure {envtmpdir} is created if it doesn't exist at the | |||
| start of a testenvironment run. Thanks Manuel Jacob. | |||
|
|
|||
| - fix #316: Lack of commands key in ini file is now treated as an error. | |||
| Reported virtualenv status is 'nothing to do' instead of 'commands | |||
| succeeded', with relevant error message displayed. Thanks Lukasz Rogalski. | |||
|
|
|||
There was a problem hiding this comment.
The changelog must not be changed retroactively, so this should not be removed. Instead a new entry for for the current version needs to be added, that this fix did not what was intended to do (throw a warning instead of causing an error) .
|
Nice catch! I've preserved + updated the changelog |
obestwalter
approved these changes
Feb 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #407
See #454 and #316
I'd rather fix this to have the following behaviour but at a glance it doesn't seem easy / possible with the current
argvlistparser (which doesn't differentiate between missing and present-but-empy):commands: warning (or error)commandsis present but empty: successfully do nothing (no warning).