Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Environment variables: Fix #2036 #2076

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Document Environment variables: Fix #2036 #2076

merged 1 commit into from
Jul 14, 2021

Conversation

majiang
Copy link

@majiang majiang commented May 29, 2021 •
edited
Loading

This is a PR for #2036.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

@majiang majiang changed the title [WIP] Environment variables [WIP] Environment variables: Fix #2036 May 29, 2021
@majiang majiang changed the title [WIP] Environment variables: Fix #2036 Document Environment variables: Fix #2036 May 30, 2021
jugmac00
jugmac00 requested changes Jun 11, 2021
View reviewed changes
Copy link
Member

@jugmac00 jugmac00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request.

I have a couple of inline annotations.

Also, could you please link to the corresponding sections in the documenation whenever you write "see ..."?

Thank you!

docs/config.rst Outdated
- ``_TOX_PARALLEL_ENV`` lets tox know that it is invoked in the parallel mode.
- ``TOX_PROVISION`` is only intended to be used internally.
- ``TOX_REPORTER_TIMESTAMP`` enables showing for each output line its delta
since the tox startup when set to ``1``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand this sentence :-/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the sentence for TOX_REPORTER_TIMESTAMP?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :-/

gaborbernat
gaborbernat approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majiang @gaborbernat
Add Environment variables section
5ef5964 
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
@gaborbernat gaborbernat merged commit eba921a into tox-dev:master Jul 14, 2021
@mimre25 mimre25 mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jugmac00 jugmac00 jugmac00 requested changes

@gaborbernat gaborbernat gaborbernat approved these changes

@asottile asottile Awaiting requested review from asottile

@obestwalter obestwalter Awaiting requested review from obestwalter

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majiang @gaborbernat @jugmac00