Document that the passenv environment setting is case insensitive #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
approved these changes
Oct 28, 2020
docs/config.rst
Outdated
| @@ -418,10 +418,12 @@ Complete list of settings that you can put into ``testenv*`` sections: | |||
|
|
|||
| A list of wildcard environment variable names which | |||
| shall be copied from the tox invocation environment to the test | |||
| environment when executing test commands. If a specified environment | |||
| environment when executing test commands. If a specified environment | |||
There was a problem hiding this comment.
I'd leave this alone, it's unrelated to your change
There was a problem hiding this comment.
Sure @asottile, I removed it
ssbarnea
pushed a commit
to ssbarnea/tox
that referenced
this pull request
Apr 19, 2021
…x-dev#1723) * Document that the passenv environment setting is case insensitive * review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Document that
passenvis case insensitive as this was not clear from the current documentation.Closes #1534
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc<your username>"superuser."CONTRIBUTORS(preserving alphabetical order)