fix non-canonical names don't work with provisioning #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Jul 1, 2019
| @@ -1161,7 +1161,7 @@ def ensure_requires_satisfied(config, requires, min_version): | |||
| # noinspection PyBroadException | |||
| try: | |||
| package = requirements.Requirement(require) | |||
| package_name = canonicalize_name(package.name) | |||
| package_name = package.name | |||
| if package_name not in exists: | |||
| deps.append(DepConfig(require, None)) | |||
| exists.add(package_name) | |||
There was a problem hiding this comment.
I think the exists set still needs canonicalization -- but the dist does not (?). The intention here was to use the canonicalization as a deduping mechanims (essentially what pkg_resources.Requirement.key was doing in tox 1.12) and it looks like I goofed and passed that to distribution(...) -- I think the minimal patch is to change the distribution call from package_name to package.name (1 character change)
There was a problem hiding this comment.
well we still need tests to validate and it's nice to break infinite loop provisioning, so a bit more characters 😄 but yeah what you say can work 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1359