Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test incorrectly includes argv[0] #61

Closed
pytoxbot opened this issue Sep 17, 2016 · 2 comments
Closed

Test incorrectly includes argv[0] #61

pytoxbot opened this issue Sep 17, 2016 · 2 comments

Comments

@pytoxbot
Copy link

One of the tests in test_venv.py fails because in fact "-i" does appear in argv[0]. Since argv[0] could be anything (I think), it makes sense to filter this out of the string being tested.

I'll attach a patch, but it's possible that more call sites which test .args should also filter out argv[0].
@pytoxbot
Copy link
Author

Original comment by @hpk42

fix #61 - always pass args[1:] from the mock-call

→ <<cset 5c050a61adc5>>

@pytoxbot
Copy link
Author

Original comment by @warsaw

@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pytoxbot