Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curly braces cannot be escaped in env substitution #1502

Closed
blueyed opened this issue Jan 17, 2020 · 2 comments · Fixed by #1696
Closed

Curly braces cannot be escaped in env substitution #1502

blueyed opened this issue Jan 17, 2020 · 2 comments · Fixed by #1696
Labels
bug:normal affects many people or has quite an impact

Comments

@blueyed
Copy link

blueyed commented Jan 17, 2020

commands = echo {env:DOESNOTEXIST:@\{u\}} results in: {env:DOESNOTEXIST:@{u}}.

Without escaping them (commands = echo {env:DOESNOTEXIST:@{u}}):

  File "/usr/lib/python3.8/site-packages/tox/config/__init__.py", line 1638, in _substitute_from_other_section
    raise tox.exception.ConfigError("substitution key {!r} not found".format(key))
tox.exception.ConfigError: ConfigError: substitution key 'u' not found

tox 3.14.3

@blueyed blueyed added the bug:normal affects many people or has quite an impact label Jan 17, 2020
@gaborbernat
Copy link
Member

Feel free to open a PR against master and fix it. My available efforts at the moment are aimed at fixing this as part of #1394, but that probably will take a while (ETA September).

@jayvdb
Copy link

jayvdb commented Oct 18, 2020

I've checked most versions back to 2.0 and this never worked.

jayvdb added a commit to jayvdb/tox that referenced this issue Oct 18, 2020
gaborbernat pushed a commit that referenced this issue Oct 18, 2020
@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
ssbarnea pushed a commit to ssbarnea/tox that referenced this issue Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug:normal affects many people or has quite an impact
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants