Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please suppress ANSI colors and progress spinner when TERM=dumb #1290

Closed
mgedmin opened this issue May 8, 2019 · 1 comment
Closed

Please suppress ANSI colors and progress spinner when TERM=dumb #1290

mgedmin opened this issue May 8, 2019 · 1 comment
Assignees
@gaborbernat
Labels
area:reporting feature:new something does not exist yet, but should help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted.
Milestone
4.0

Comments

@mgedmin
Copy link
Contributor

mgedmin commented May 8, 2019 •
edited
Loading

I'm often running things like tox -p auto -e py27,py35 -- testfile::test_function from Vim, using its builtin quickfix window to look at the errors. (I've a plugin that runs the test under cursor with a single keystroke, it's very convenient.)

This is what I see with tox 3.9.0:

Ekrano nuotrauka iš 2019-05-08 18-09-22
...
Ekrano nuotrauka iš 2019-05-08 18-09-39

It would be amazing if tox noticed that $TERM was set to dumb and did not output all these ^M^[s
@mgedmin mgedmin added the feature:new something does not exist yet, but should label May 8, 2019
@gaborbernat gaborbernat added help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted. area:reporting labels May 8, 2019
@blueyed blueyed mentioned this issue Nov 4, 2019
Closed
@gaborbernat
Copy link
Member

on TERM dumb we should use ascii frames here https://github.com/tox-dev/tox/blob/rewrite/src/tox/util/spinner.py#L65

@gaborbernat gaborbernat added this to the 4.0 milestone Jan 13, 2022
@gaborbernat gaborbernat self-assigned this Jan 26, 2022
ssbarnea added a commit to ssbarnea/tox that referenced this issue Nov 20, 2022
@ssbarnea
Disable coloring with TERM=dumb or NO_COLOR
a63fdb5 
Fixes: tox-dev#1290

Related: https://no-color.org/
@ssbarnea ssbarnea mentioned this issue Nov 20, 2022
Merged
6 tasks
ssbarnea added a commit to ssbarnea/tox that referenced this issue Nov 21, 2022
@ssbarnea
Disable coloring with TERM=dumb or NO_COLOR
9d5bcff 
Fixes: tox-dev#1290

Related: https://no-color.org/
ssbarnea added a commit to ssbarnea/tox that referenced this issue Nov 21, 2022
@ssbarnea
Disable coloring with TERM=dumb or NO_COLOR
879a6c0 
Fixes: tox-dev#1290

Related: https://no-color.org/
ssbarnea added a commit to ssbarnea/tox that referenced this issue Nov 21, 2022
@ssbarnea
Disable coloring with TERM=dumb or NO_COLOR
1f2bd20 
Fixes: tox-dev#1290

Related: https://no-color.org/
gaborbernat pushed a commit that referenced this issue Nov 22, 2022
@ssbarnea @pre-commit-ci
Disable coloring with TERM=dumb or NO_COLOR (#2541)
991ac4d 
* Disable coloring with TERM=dumb or NO_COLOR

Fixes: #1290

Related: https://no-color.org/

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add changelog fragment

* Fixed logic

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaborbernat gaborbernat

Labels
area:reporting feature:new something does not exist yet, but should help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted.
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
2 participants
@mgedmin @gaborbernat