Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--workdir: resolve symlinks or warn about it #1169

Closed
blueyed opened this issue Feb 21, 2019 · 0 comments
Closed

--workdir: resolve symlinks or warn about it #1169

blueyed opened this issue Feb 21, 2019 · 0 comments
Labels
area:configuration bug:minor does not affect many people or has no big impact

Comments

@blueyed
Copy link

blueyed commented Feb 21, 2019

I've noticed a strange issue, where running an entry point wrapper script behaved differently with tox --workdir=symlink vs. tox --workdir=resolved_path (nedbat/coveragepy#777).
The main difference here appears to be with/how Python's import machinery behaves in this case.

Therefore I think it would be good to resolve any symlinks in the workdir, or at least trigger a warning.
blueyed added a commit to blueyed/tox that referenced this issue Feb 22, 2019
@blueyed
toxworkdir: use realpath
1accf3d 
Fixes tox-dev#1169.
@blueyed blueyed mentioned this issue Feb 22, 2019
Merged
@gaborbernat gaborbernat added bug:minor does not affect many people or has no big impact area:configuration labels Feb 22, 2019
blueyed added a commit to blueyed/tox that referenced this issue Feb 22, 2019
@blueyed
toxworkdir: use realpath
ea9e20a 
Fixes tox-dev#1169.
blueyed added a commit to blueyed/tox that referenced this issue Feb 23, 2019
@blueyed
toxworkdir: use realpath
76f873e 
Fixes tox-dev#1169.
blueyed added a commit to blueyed/tox that referenced this issue Feb 23, 2019
@blueyed
toxworkdir: use realpath
91ede62 
Fixes tox-dev#1169.
gaborbernat pushed a commit that referenced this issue Feb 24, 2019
@blueyed @gaborbernat
toxworkdir: use realpath (#1171)
6dbd865 
* toxworkdir: use realpath

Fixes #1169.

* ensure tox.ini

* no need for --help anymore

* use tmp_path

* changelog
@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area:configuration bug:minor does not affect many people or has no big impact
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blueyed @gaborbernat