Skip to content

Commit

Permalink
Increase timeout for VPA v1 e2e tests
Browse files Browse the repository at this point in the history
With switch to ginkgo v2 timeout are counted differently[1]. With Ginkgo v1
timeout was per-test-suite. Now its for the whole test run. As a result
`actuation` [2] tests for `v1` API are timing out. They take a little more than
60 minutes. For example passing run [3] logs first '[v1]' at 19:30:23.701
and the last one at 20:33:44.510.

[1] https://onsi.github.io/ginkgo/MIGRATING_TO_V2#timeout-behavior
[2] https://k8s-testgrid.appspot.com/sig-autoscaling-vpa#autoscaling-vpa-actuation
[3] https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-e2e-autoscaling-vpa-actuation/1564683608667459584/build-log.txt
  • Loading branch information
jbartosik committed Aug 31, 2022
1 parent 035e762 commit d910668
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion vertical-pod-autoscaler/hack/run-e2e-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ case ${SUITE} in
recommender|updater|admission-controller|actuation|full-vpa)
export KUBECONFIG=$HOME/.kube/config
pushd ${SCRIPT_ROOT}/e2e
go test -mod vendor ./v1beta2/*go -v --test.timeout=60m --args --ginkgo.v=true --ginkgo.focus="\[VPA\] \[${SUITE}\]" --report-dir=/workspace/_artifacts --disable-log-dump
go test -mod vendor ./v1beta2/*go -v --test.timeout=90m --args --ginkgo.v=true --ginkgo.focus="\[VPA\] \[${SUITE}\]" --report-dir=/workspace/_artifacts --disable-log-dump
V1BETA2_RESULT=$?
go test -mod vendor ./v1/*go -v --test.timeout=90m --args --ginkgo.v=true --ginkgo.focus="\[VPA\] \[${SUITE}\]" --report-dir=/workspace/_artifacts --disable-log-dump
V1_RESULT=$?
Expand Down

0 comments on commit d910668

Please sign in to comment.