Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InitCommand - If the new key and <file> don't match, prompt for confirmation #236

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

totten
Copy link
Owner

@totten totten commented Feb 12, 2022

Screen Shot 2022-02-12 at 3 58 44 AM

@colemanw
Copy link
Contributor

Looks good 👍

@totten
Copy link
Owner Author

totten commented Feb 14, 2022

Thank you @demeritcowboy !

I've done some more copy-edits on both the help screen and the interactive screen. Hopefully, all the sentences are complete... 🙃

Screen Shot 2022-02-14 at 1 49 01 PM

Screen Shot 2022-02-14 at 1 48 40 PM

$output->writeln("requested command requires splitting the names. You may continue with");
$output->writeln("split names, or you may cancel and try again with a simpler name.");
$output->writeln("");
if (!$this->confirm($input, $output, "Continue with current (split) name? [Y/n] ")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work on windows but that's come up elsewhere so isn't something new, just is new in this command. The workaround is just don't use dots.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, curious. I don't have a good setup to try it out. FWIW, that's a thin wrapper around Symfony ConfirmationQuestion. Theories:

  • The command somehow gets option--yes.
  • There's a discrepancy in the version of symfony/console. (Ex: My local has v4.4.34)
  • There's an upstream issue with ConfirmationQuestion in the active version of symfony/console.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh - symfony/console version. I must have not run composer install anytime recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants