Add UIView.AnimationOptions variable to KeyboardOptions struct #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to smoothly animate our views at par with iOS keyboard, UIView.animate method takes an UViewAnimationOptions value. Right now we must convert KeyboardOptions.animationCurve from UIView.AnimationCurve to UIView.AnimationOptions. To make our code cleaner I've implemented a helper variable animationOptions which transforms a given UIView.AnimationCurve to its respective UIView.AnimationOptions value.
|
Awesome! Can you update docs in README to reflect this change? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to smoothly animate our views at par with iOS keyboard, we must use
UIView.animate(withDuration:delay:options:animations:completion:)method which takesUIViewAnimationOptionsas it's options argument value.Right now we must convert
KeyboardOptions.animationCurvefromUIView.AnimationCurvetoUIView.AnimationOptionsin order to call ouranimatefunction.To make our lives easier and our code cleaner, I've implemented a helper variable called
animationOptionsinTypist.KeyboardOptionsstruct, which transforms a givenUIView.AnimationCurveto its respectiveUIView.AnimationOptionsvalue.