Skip to content

Commit

Permalink
libnvdimm: clean up command definitions
Browse files Browse the repository at this point in the history
Remove the command payloads that do not have an associated libnvdimm
ioctl. I.e. remove the payloads that would only ever be carried in the
ND_CMD_CALL envelope. This prevents userspace from growing unnecessary
dependencies on this kernel header when userspace already has everything
it needs to craft and send these commands.

Cc: Jerry Hoemann <jerry.hoemann@hpe.com>
Reported-by: Yasunori Goto <y-goto@jp.fujitsu.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
  • Loading branch information
djbw committed Aug 28, 2017
1 parent cc4a41f commit 7a14724
Showing 1 changed file with 0 additions and 37 deletions.
37 changes: 0 additions & 37 deletions include/uapi/linux/ndctl.h
Original file line number Diff line number Diff line change
Expand Up @@ -145,43 +145,6 @@ struct nd_cmd_clear_error {
__u64 cleared;
} __packed;

struct nd_cmd_trans_spa {
__u64 spa;
__u32 status;
__u8 flags;
__u8 _reserved[3];
__u64 trans_length;
__u32 num_nvdimms;
struct nd_nvdimm_device {
__u32 nfit_device_handle;
__u32 _reserved;
__u64 dpa;
} __packed devices[0];

} __packed;

struct nd_cmd_ars_err_inj {
__u64 err_inj_spa_range_base;
__u64 err_inj_spa_range_length;
__u8 err_inj_options;
__u32 status;
} __packed;

struct nd_cmd_ars_err_inj_clr {
__u64 err_inj_clr_spa_range_base;
__u64 err_inj_clr_spa_range_length;
__u32 status;
} __packed;

struct nd_cmd_ars_err_inj_stat {
__u32 status;
__u32 inj_err_rec_count;
struct nd_error_stat_query_record {
__u64 err_inj_stat_spa_range_base;
__u64 err_inj_stat_spa_range_length;
} __packed record[0];
} __packed;

enum {
ND_CMD_IMPLEMENTED = 0,

Expand Down

0 comments on commit 7a14724

Please sign in to comment.