Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FF-5] Migrate cx to tailwind-merge in SidebarMenu #4694

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

rocodesign
Copy link
Contributor

@rocodesign rocodesign commented Mar 11, 2025

FF-5

Description

Migrate cx to tailwind-merge in SidebarMenu

How to test

  • No visual changes should occur

Screenshots

No visual changes

Development checks

  • Add changeset according to guidelines (if needed)
  • Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • Covered with tests (visual tests included)

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping for reviews
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@rocodesign rocodesign requested a review from a team as a code owner March 11, 2025 12:35
@rocodesign rocodesign self-assigned this Mar 11, 2025
Copy link

changeset-bot bot commented Mar 11, 2025

🦋 Changeset detected

Latest commit: c583e66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@toptal/picasso-page Patch
@toptal/picasso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rocodesign
Copy link
Contributor Author

@toptal-anvil ping reviewers

Copy link
Contributor

@diogolessa diogolessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Happo errors are unrelated.

@rocodesign rocodesign force-pushed the ff-5-sidedebar-menu-cs-tw branch from 7e08181 to 05c7dc7 Compare March 12, 2025 10:33
@rocodesign rocodesign enabled auto-merge (squash) March 12, 2025 10:34
@rocodesign rocodesign force-pushed the ff-5-sidedebar-menu-cs-tw branch from 05c7dc7 to c583e66 Compare March 17, 2025 12:01
@rocodesign rocodesign merged commit da9f360 into master Mar 17, 2025
17 checks passed
@rocodesign rocodesign deleted the ff-5-sidedebar-menu-cs-tw branch March 17, 2025 12:36
@toptal-build toptal-build mentioned this pull request Mar 17, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants