Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bindings to the new API. #193

Merged
merged 10 commits into from
Jul 9, 2024
Merged

Update bindings to the new API. #193

merged 10 commits into from
Jul 9, 2024

Conversation

ske2004
Copy link
Member

@ske2004 ske2004 commented Jul 7, 2024

Goals:

  • Add the Umka prototype of the function above every corresponding C function.

  • Convert from struct pointers to values where needed.

  • Move struct return values to result, instead of pointer parameters.

  • Do the remaining bindings

  • Test the bindings

    • Works on all samples and demos.
    • Works on Savescum.

@ske2004 ske2004 marked this pull request as ready for review July 7, 2024 20:42
@ske2004 ske2004 marked this pull request as draft July 7, 2024 20:42
@ske2004 ske2004 requested a review from marekmaskarinec July 7, 2024 20:42
@ske2004 ske2004 changed the title Fix bindings up until end of image.um Update bindings to the new format. Jul 7, 2024
@ske2004 ske2004 changed the title Update bindings to the new format. Update bindings to the new API. Jul 7, 2024
@ske2004
Copy link
Member Author

ske2004 commented Jul 8, 2024

@marekmaskarinec Please verify that I converted ent.um correctly.

@ske2004 ske2004 marked this pull request as ready for review July 9, 2024 22:37
@ske2004 ske2004 merged commit 53d0469 into main Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants