Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proper error handling (#157) #166

Merged
merged 14 commits into from
Mar 14, 2024
Merged

Implement proper error handling (#157) #166

merged 14 commits into from
Mar 14, 2024

Conversation

marekmaskarinec
Copy link
Member

No description provided.

@marekmaskarinec
Start work on error handling
7d4cde8 
Signed-off-by: Marek Maškarinec <marek@mrms.cz>
@marekmaskarinec marekmaskarinec requested a review from ske2004 March 11, 2024 12:31
ske2004
ske2004 requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@ske2004 ske2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes overall. I will do some testing later, but check the comments for now.

@marekmaskarinec
Fix compile errors
084b1f3 
Signed-off-by: Marek Maškarinec <marek@mrms.cz>
@marekmaskarinec
Revert change
166904b 
Signed-off-by: Marek Maškarinec <marek@mrms.cz>
@ske2004
Copy link
Member

ske2004 commented Mar 12, 2024 •
edited
Loading

You missed one module, csv.um, but I think we need to update the Umka version first.

Edit: nvm csv doesn't use the filesystem

marekmaskarinec and others added 5 commits March 12, 2024 20:12
@marekmaskarinec
Remove ErrCode.err
0e1da08 
Signed-off-by: Marek Maškarinec <marek@mrms.cz>
@marekmaskarinec
Add missing error strings
4df8b6d 
Signed-off-by: Marek Maškarinec <marek@mrms.cz>
@marekmaskarinec
Fix some tests
bc55079 
Signed-off-by: Marek Maškarinec <marek@mrms.cz>
@ske2004
Fix flappy
9fc1dbe
@ske2004
Fix tetris
4d8d854
@marekmaskarinec
Copy link
Member Author

You missed one module, csv.um, but I think we need to update the Umka version first.

Edit: nvm csv doesn't use the filesystem

In the future, we might want to add proper error handling to csv.um. (Or go with my preferred and remove it in favor of csv from umbox).

@ske2004
Copy link
Member

ske2004 commented Mar 13, 2024

I think the changes are good now, we just need to fix the rest of the tests and examples.

@marekmaskarinec
fix rest of the tests
e8ead14 
Signed-off-by: Marek Maškarinec <marek@mrms.cz>
@marekmaskarinec
Copy link
Member Author

All tests are now updated.

@marekmaskarinec
Fix space shooter and platformer
fabf763 
Signed-off-by: Marek Maškarinec <marek@mrms.cz>
@marekmaskarinec
Copy link
Member Author

Only pomodoro is left to fix

@ske2004
Copy link
Member

ske2004 commented Mar 13, 2024

alright i'm gonna do it quick

ske2004
ske2004 requested changes Mar 13, 2024
View reviewed changes
ske2004
ske2004 reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@ske2004 ske2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we handle the errors or ignore as we do now?

@marekmaskarinec marekmaskarinec changed the title Start work on error handling Implement proper error handling Mar 14, 2024
@marekmaskarinec marekmaskarinec changed the title Implement proper error handling Implement proper error handling (#157) Mar 14, 2024
@marekmaskarinec marekmaskarinec merged commit a929d8f into main Mar 14, 2024
@marekmaskarinec marekmaskarinec deleted the marek/err branch March 14, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ske2004 ske2004 ske2004 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marekmaskarinec @ske2004