Sanitize control characters in input str (#144) #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will work for UI but I think it's actually better to sanitize it from within Tophat itself, because we don't really want inconsistent behavior across platforms. |
ske2004
reviewed
Mar 11, 2024
Signed-off-by: Marek Maškarinec <marek@mrms.cz>
cbeb9a2 to
ef140e4
Compare
|
I'll test and merge if it works. |
|
Ok, it doesn't work but there's a simple reason, the problematic character is DEL, whose code is 127. I can fix that though. My main concern is, do we include |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.