This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
feat: handle retrying on the client, not service #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawndrape
reviewed
Aug 18, 2022
packages/client/src/runTests.ts
Outdated
| const invokeResult = await invokeBackend.invoke({ | ||
| config: { | ||
| ...config, | ||
| retryCount: 0, // client will take care of retrying |
There was a problem hiding this comment.
Why does the invoke need the retryCount? I don't see how the thing being retried gets to interact with the count.
There was a problem hiding this comment.
The retry count gets passed to the service currently because the service used to do the retrying. This zeroes it out so only the client retries.
shawndrape
reviewed
Aug 19, 2022
0e49a47 to
aa0005c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lambda has a time limit so we should handle retrying on the client, not the service.
TODO:
QAd with local invoke.