Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aura since v4.0.6 does not need sudo #908

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

SteveLauC
Copy link
Member

What does this PR do

Aura since version 4.0.6 no longer needs sudo, so let's fix it on Topgrade's side.

Closes #907

Standards checklist

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@SteveLauC
Copy link
Member Author

Hi @ellsclytn, here is a build for Linux with this patch included, please give it a test:)

@ellsclytn
Copy link

Hey @SteveLauC, gave it a little go, but unfortunately hit an error:

image

Also, I've just realised that Aura now fails when sudo is supplied for both AUR and Pacman operations:

image

I'd initially assumed it would only be for AUR stuff, but looks like that's not the case.

@SteveLauC
Copy link
Member Author

but unfortunately hit an error:

Looks like I need to remove 'aura' from the output

I'd initially assumed it would only be for AUR stuff, but looks like that's not the case.

No worries, I handled both in this PR 😄

@SteveLauC
Copy link
Member Author

SteveLauC commented Sep 16, 2024

Looks like I need to remove 'aura' from the output

Build updated, please try it, it should work this time:)

@ellsclytn
Copy link

Worked perfectly 🎉

@SteveLauC
Copy link
Member Author

Thanks for testing it, merging!

@SteveLauC SteveLauC merged commit 25d3a81 into topgrade-rs:main Sep 16, 2024
11 checks passed
@SteveLauC SteveLauC deleted the fix/aura branch September 16, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aura refuses to run if sudo is supplied
2 participants