Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pyenv: no such command 'update' #860

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix pyenv: no such command 'update' #860

merged 1 commit into from
Jul 10, 2024

Conversation

lucaspar
Copy link
Contributor

@lucaspar lucaspar commented Jul 10, 2024 •
edited
Loading

What does this PR do

Additional check before pyenv update is called. Fixes #849 when pyenv is managed by Homebrew or installed by cloning the repo without the required update plugin.

Standards checklist

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself

Try it by running

cargo run -- --verbose --only pyenv

SteveLauC
SteveLauC approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it!

@SteveLauC SteveLauC merged commit 07118fa into topgrade-rs:main Jul 10, 2024
11 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveLauC SteveLauC SteveLauC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The pyenv step fails unless the pyenv-update plugin is installed
2 participants
@lucaspar @SteveLauC