-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve Windows Update step and add PSWindowsUpdate Module #842
Conversation
Refactor the `windows_update` function in `windows.rs` to improve the Windows Update step. Added a prompt for administrator privileges and updated the warning message. Also, added support for installing the PSWindowsUpdate Module as an alternative to using USOClient for Windows Update. still see warning: The installer will request to run as administrator, expect a prompt. Start-Process : A parameter cannot be found that matches parameter name 'Command'. At line:1 char:74 + ... ath powershell -Verb runAs -ArgumentList -NoProfile -Command Import- ... + ~~~~~~~~ + CategoryInfo : InvalidArgument: (:) [Start-Process], ParameterBindingException + FullyQualifiedErrorId : NamedParameterNotFound,Microsoft.PowerShell.Commands.StartProcessCommand VERBOSE: MSI-THIN-GF36 (6/30/2024 4:48:48 PM): Connecting to Microsoft Update server. Please wait... VERBOSE: Found [0] Updates in pre search criteria but as the verbose shows it works
Blocked by #871 |
Fixed now |
Thanks for the patch! cc @BoYanZh @BobG1983, could you guys give this patch a try and see if it addresses your issues? If you don't have a Rust toolchain installed, I can build Topgrade with this patch in my Windows VM, but I am not familiar with Windows, if I directly send the exe file, is it executable on your machines? |
I have tried it and it works! I built it with |
Nice, thanks for testing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this PR
Refactor the
windows_update
function inwindows.rs
to improve the Windows Update step. Added a prompt for administrator privileges and updated the warning message. Also, added support for installing the PSWindowsUpdate Module as an alternative to using USOClient for Windows Update.still see warning:
The installer will request to run as administrator, expect a prompt.
Start-Process : A parameter cannot be found that matches parameter name 'Command'.
At line:1 char:74
VERBOSE: MSI-THIN-GF36 (6/30/2024 4:48:48 PM): Connecting to Microsoft Update server. Please wait...
VERBOSE: Found [0] Updates in pre search criteria
but as the verbose shows it works
What does this PR do
Standards checklist
CONTRIBUTING.md
For new steps
--dry-run
option works with this step--yes
option works with this step if it is supported bythe underlying command
If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.