refactor(powershell): streamline command construction for Windows upd…

…ates
topgrade-rs · Feb 15, 2025 · 2ece72a · 2ece72a
1 parent 2310014
commit 2ece72a
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/steps/powershell.rs b/src/steps/powershell.rs
@@ -148,11 +148,13 @@ mod windows {
 
     pub fn windows_update(powershell: &Powershell, ctx: &ExecutionContext) -> Result<()> {
         debug_assert!(supports_windows_update(powershell));
-        let mut cmd = powershell.build_command_internal(ctx, &["Install-WindowsUpdate -Verbose"])?;
+
+        let mut args = vec!["Install-WindowsUpdate", "-Verbose"];
         if ctx.config().accept_all_windows_updates() {
-            cmd.arg("-AcceptAll");
+            args.push("-AcceptAll");
         }
-        cmd.status_checked()
+
+        powershell.build_command_internal(ctx, &args)?.status_checked()
     }
 
     pub fn microsoft_store(powershell: &Powershell, ctx: &ExecutionContext) -> Result<()> {