Bug fix where ActiveGameIndex is not set correctly on program Startup #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey good, I hope you are well. After a lot of time coding and very little because university things I started adding functionalities for ASC 3.0 after my new interface was finished.
I have a problem with the combobox that we used to set the active splitter did'nt set on Startup,
BEFORE HCM INTERFACE IMPLEMENT
AFTER HCM INTERFACE IMPLEMENT
You added
interfaceASC.ActiveGameIndex = GetSplitterEnable();
on ASC in RegisterHitCounterManagerInterface() Functionbut the problem for manage this by the function is that called before fill ComboBox on HCM, then this raises an OutOfRange exception in the comboBox, to fix this im added GetActiveGameIndexMethod Function.
Remember that now ASC Fill ObservableCollection GameList after AutoSplitterRegisterInterface is invocated.
I dont know why PracticeMode still working but if it works that's enough, maybe is manage by other function.
I have the solution for V2.X but i cant do a PR because
There is a commits before or affter in the current branch so I can't do it without breaking everything
Im attach the files that i change
HitCounterManagerV2-Fix.zip