Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fox Pet #343

Merged
merged 8 commits into from
Dec 13, 2022
Merged

Add Fox Pet #343

merged 8 commits into from
Dec 13, 2022

Conversation

nikelasi
Copy link
Contributor

Adds fox as mentioned in #324 and a snow (white) variant.
Adds attribution the original author of the assets in the README
orange_lie_8fps
white_run_8fps

@tonybaloney
Copy link
Owner

This is brilliant, thank you! the animations are gorgeous.

Please could you set the colours as red and white instead of orange and white. We already have red as a colour preset.

@codecov-commenter
Copy link

Codecov Report

Merging #343 (34d371a) into master (0ad77ab) will increase coverage by 2.48%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   14.34%   16.82%   +2.48%     
==========================================
  Files          17       20       +3     
  Lines         774     1129     +355     
  Branches      103      152      +49     
==========================================
+ Hits          111      190      +79     
- Misses        663      933     +270     
- Partials        0        6       +6     
Impacted Files Coverage Δ
src/common/types.ts 71.42% <ø> (ø)
src/panel/pets.ts 20.20% <33.33%> (+0.41%) ⬆️
src/panel/pets/fox.ts 50.00% <50.00%> (ø)
src/common/localize.ts 42.85% <0.00%> (ø)
src/extension/extension.ts 21.06% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nikelasi
Copy link
Contributor Author

Sure, I'll do that, and I also realised I didn't add the fox in alphabetical order with the rest of the pets so I'll fix that as well

@tonybaloney
Copy link
Owner

I also realised we'll be adding both foxes and chickens in the same release. This is going to be chaos 🤣 . @gulyapulya @MhouneyLH

@tonybaloney
Copy link
Owner

screenshot 2022-12-13 at 12 51 47
because the fox has quite a lot of padding in the GIFs, it comes out as tiny compared with other pets. You'll need to crop the GIF frames whilst maintaining the same aspect ratio.

src/panel/pets.ts Outdated Show resolved Hide resolved
@gulyapulya
Copy link
Contributor

Btw, @NicholasJohansan, did you create the white one yourself? How did you change the color? Did you use filter? I am trying to create more colors for chicken, so looking for techniques.

@nikelasi
Copy link
Contributor Author

Btw, @NicholasJohansan, did you create the white one yourself? How did you change the color? Did you use filter? I am trying to create more colors for chicken, so looking for techniques.

Yea, I created the white one myself. In Aseprite, it's possible to change the color pallete, so I just edited the shades of orange colors to be shades of white.

@nikelasi
Copy link
Contributor Author

done, hopefully the cropping is ok

@tonybaloney
Copy link
Owner

tonybaloney commented Dec 13, 2022

screenshot 2022-12-13 at 13 45 12
much better (although the chicken now seems massive!)

@tonybaloney tonybaloney merged commit 63c1546 into tonybaloney:master Dec 13, 2022
@tonybaloney tonybaloney mentioned this pull request Dec 13, 2022
@MhouneyLH
Copy link
Contributor

MhouneyLH commented Dec 13, 2022

Then I worry about the chickens.😂 @tonybaloney

@gulyapulya
Copy link
Contributor

gulyapulya commented Dec 13, 2022

@tonybaloney, the fox still seems small to me, shouldn't we enlarge the fox to be at least the size of a dog or a cat? 😅
Or if you decide, then we can make chicken smaller.

@MhouneyLH
Copy link
Contributor

@tonybaloney, the fox still seems small to me, shouldn't we enlarge the fox to be at least the size of a dog or a cat? 😅 Or if you decide, then we can make chicken smaller.

I agree with this. It seems like the chicken could eat the fox in this version. 😂

@nikelasi
Copy link
Contributor Author

I think the chicken is the one that's too big, from the gif, the fox looks like the same size as the cat
image

tonybaloney added a commit that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants