Added Clippy Message #209
Merged
Added Clippy Message #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tonybaloney Added Custom Clippy Message, with reference to Windows 97's official Clippy. |
tonybaloney
approved these changes
Oct 9, 2022
tonybaloney
requested changes
Oct 9, 2022
| @@ -800,7 +800,7 @@ export class Clippy extends BasePetType { | |||
| } | |||
| hello(): string { | |||
| // TODO: #188 Add a custom message for clippy | |||
| return ` says hello 👋!`; | |||
There was a problem hiding this comment.
Please remove the line above with the todo as this will be closed with the merged PR
There was a problem hiding this comment.
I have removed the comment @tonybaloney.
tonybaloney
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Custom Clippy Message, with reference related to Windows 97's Clippy.
Closes #188