Added Duck Message #206
Merged
Added Duck Message #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Solves Issue #190 @tonybaloney |
|
@akk312000 I think we should implement a list of several messages, instead of using only one message per pet. And we can randomize it. wdyt @tonybaloney ? |
|
Seems like a great idea to me @rosdyana , would still prefer @tonybaloney's inputs here. |
I like the idea. please suggest it in the issues list. I'll merge this for now. |
tonybaloney
reviewed
Oct 9, 2022
src/panel/pets.ts
Outdated
| @@ -816,7 +816,7 @@ export class RubberDuck extends BasePetType { | |||
| } | |||
| hello(): string { | |||
| // TODO: #190 Add a custom message for duck | |||
| return ` says hello 👋!`; | |||
| return ` Hi, I'm Donald Duck and I love to Quack around 👋!`; | |||
There was a problem hiding this comment.
I'm gonna leave this as "I love to quack around", because it'll be confusing to have the name of the duck and then a message saying they're called Donald Duck
tonybaloney
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Custom message for Duck Pet