Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a UV package manager #327

Merged
merged 17 commits into from
Jan 13, 2025
Merged

Add a UV package manager #327

merged 17 commits into from
Jan 13, 2025

Conversation

tonybaloney
Copy link
Owner

Related #326

@tonybaloney tonybaloney mentioned this pull request Jan 11, 2025
3 tasks
@tonybaloney tonybaloney requested a review from Copilot January 13, 2025 05:04
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 12 changed files in this pull request and generated 1 comment.

Files not reviewed (6)
  • src/Directory.Packages.props: Language not supported
  • src/RedistributablePython.Tests/RedistributablePython.Tests.csproj: Language not supported
  • docs/index.md: Evaluated as low risk
  • src/CSnakes.Runtime/PackageManagement/PipInstaller.cs: Evaluated as low risk
  • .github/workflows/dotnet-ci.yml: Evaluated as low risk
  • src/RedistributablePython.Tests/RedistributablePythonTestBase.cs: Evaluated as low risk
Comments suppressed due to low confidence (4)

src/CSnakes.Runtime/PackageManagement/UVInstaller.cs:33

  • The command string should use 'uv' instead of 'pip' to install packages. Change it to 'string arguments = "uv install {requirements}";'.
string arguments = "pip install {requirements}";

src/CSnakes.Runtime/PackageManagement/UVInstaller.cs:54

  • The dictionary 'extraEnv' is being initialized with potentially null values from environment variables. Ensure that null values are handled appropriately before adding them to the dictionary.
{ "UV_CACHE_DIR", Environment.GetEnvironmentVariable("UV_CACHE_DIR") },

src/CSnakes.Runtime/PackageManagement/IPythonPackageInstaller.cs:41

  • The use of string interpolation in the logger.LogDebug call is inconsistent with the rest of the logging statements, which use structured logging. Consider changing it to logger.LogDebug("Running {FileName} with args {Arguments} from {WorkingDirectory}", startInfo.FileName, startInfo.Arguments, startInfo.WorkingDirectory);
logger.LogDebug($"Running {startInfo.FileName} with args {startInfo.Arguments} from {startInfo.WorkingDirectory}");

src/RedistributablePython.Tests/BasicTests.cs:8

  • [nitpick] The test method name 'TestSimpleRedistributableImport' is ambiguous. Consider renaming it to something more descriptive, such as 'TestRedistributablePythonSimpleImport'.
public void TestSimpleRedistributableImport()

@tonybaloney tonybaloney merged commit 606e883 into main Jan 13, 2025
25 checks passed
@tonybaloney tonybaloney deleted the uv2 branch January 13, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant