New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make type name patterns explicit where `typing.` qualification is optional #267

Merged

aaronpowell merged 1 commit into tonybaloney:main from atifaziz:type-patterns

Oct 14, 2024

Contributor

atifaziz commented Oct 13, 2024 •

edited

Loading

This was a little hard to parse, is somewhat fragile and potentially allocates:

CSnakes/src/CSnakes.SourceGeneration/Reflection/TypeReflection.cs

Line 23 in efd03f8

return pythonType.Name.Replace("typing.", "") switch

This PR proposes to use explicit or patterns instead for the following benefits (in order of importance):

Clear and explicit cases of what's accepted, e.g. "typing.Dict" or "Dict"
typing. isn't just removed anywhere in the name (always a prefix) to avoid accidental matches
No new string allocation in case Replace the effect of removing the string

I added tests for cases that were previously uncovered to make sure nothing was broken by this PR (unless I got the intent wrong).


          Make type name patterns explicit where "typing." is optional

e4d60dc

aaronpowell approved these changes

View reviewed changes

aaronpowell merged commit 7a18e2e into tonybaloney:main

37 checks passed

atifaziz deleted the type-patterns branch

October 14, 2024 05:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet