Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CSnake project to CSnake.SourceGeneration and unify nupkgs #211

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Rename CSnake project to CSnake.SourceGeneration and unify nupkgs #211

merged 2 commits into from
Sep 19, 2024

Conversation

RussKie
Copy link
Contributor

@RussKie RussKie commented Sep 18, 2024 •
edited
Loading

  • Rename CSnake project to CSnake.SourceGeneration (Resolves Rename CSnake project to CSnake.SourceGeneration #209)
    image

  • Repackage the source generator into the runtime package
    image
    The SG can be disabled by the consumer project by settings the following MSBuild property:

    <DisableCSnakesRuntimeSourceGenerator>true</DisableCSnakesRuntimeSourceGenerator>

@RussKie
Copy link
Contributor Author

RussKie commented Sep 18, 2024

The Samples CI fails because there's no CSnake.SourceGeneration package exists on the nuget feed.

@tonybaloney
Copy link
Owner

Looks like this also reformats a lot of the source code. it will introduce a lot of merge conflicts. Suggest we check what else is in the backlog first

@RussKie
Copy link
Contributor Author

RussKie commented Sep 18, 2024

Looks like this also reformats a lot of the source code. it will introduce a lot of merge conflicts. Suggest we check what else is in the backlog first

I've moved files due to the folder rename. Git should handle this just fine.

@tonybaloney
Copy link
Owner

Looks like there are some merge conflicts

@RussKie RussKie force-pushed the 290 branch 2 times, most recently from 6bfbd74 to 70acf81 Compare September 18, 2024 10:54
@RussKie
Copy link
Contributor Author

RussKie commented Sep 18, 2024

Looks like there are some merge conflicts

Resolved

@RussKie RussKie marked this pull request as draft September 18, 2024 10:56
@RussKie
Copy link
Contributor Author

RussKie commented Sep 18, 2024

The Samples are failing because they require the new nupkg with the SG packaged in.

@RussKie RussKie marked this pull request as ready for review September 18, 2024 11:17
@RussKie RussKie changed the title Rename CSnake project to CSnake.SourceGeneration Rename CSnake project to CSnake.SourceGeneration and unify nupkgs Sep 18, 2024
@RussKie
Copy link
Contributor Author

RussKie commented Sep 18, 2024

/cc: @aaronpowell FYI

@RussKie
Package the SG into the runtime package
0e6fbf8 
The SG can be disabled by the consumer project by settings the following
MSBuild property:

    <DisableCSnakesRuntimeSourceGenerator>true</DisableCSnakesRuntimeSourceGenerator>
@RussKie RussKie mentioned this pull request Sep 19, 2024
Merged
aaronpowell
aaronpowell reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a single NuGet package now called CSnakes.Runtime?

src/CSnakes.SourceGeneration/CaseHelper.cs Show resolved Hide resolved
@RussKie
Copy link
Contributor Author

RussKie commented Sep 19, 2024

Is it a single NuGet package now called CSnakes.Runtime?

Correct. See the screenshot above

@tonybaloney tonybaloney merged commit db7c42a into tonybaloney:main Sep 19, 2024
34 of 37 checks passed
@RussKie RussKie deleted the 290 branch September 19, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonybaloney tonybaloney tonybaloney approved these changes

@aaronpowell aaronpowell aaronpowell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename CSnake project to CSnake.SourceGeneration
3 participants
@RussKie @tonybaloney @aaronpowell