Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CS8604 (possible null dereferencing) warnings #205

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

atifaziz
Copy link
Contributor

This PR addressed the following two CS8604 warnings:

A:\CSnakes\main\src\CSnakes.Runtime\Locators\NuGetLocator.cs(15,102): warning CS8604: Possible null reference argument for parameter 'path1' in 'string Path.Combine(string path1, string path2, string path3)'. [A:\CSnakes\main\src\CSnakes.Runtime\CSnakes.Runtime.csproj]
A:\CSnakes\main\samples\Aspire\CSnakesAspire.ApiService\Program.cs(65,88): warning CS8602: Dereference of a possibly null reference. [A:\CSnakes\main\samples\Aspire\CSnakesAspire.ApiService\CSnakesAspire.ApiService.csproj]

that were being flagged during build and also adding a lot of GH Actions annotation noise in PR diffs:

image

@tonybaloney
Copy link
Owner

Thanks!!

@tonybaloney tonybaloney merged commit 3cdbd44 into tonybaloney:main Sep 17, 2024
24 of 26 checks passed
@atifaziz atifaziz deleted the fix/CS8604 branch September 17, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants