Convert ndarray scalars to Span<T> using the buffer protocol #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybaloney
commented
Sep 5, 2024
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
|
Linux tests are failing because of #189 Rest of the implementation I'm happy with |
aaronpowell
approved these changes
Sep 15, 2024
RussKie
reviewed
Sep 16, 2024
Co-authored-by: Igor Velikorossov <RussKie@users.noreply.github.com>
…into numpy_tests
aaronpowell
requested changes
Sep 17, 2024
Co-authored-by: Aaron Powell <me@aaron-powell.com>
…into numpy_tests
aaronpowell
approved these changes
Sep 17, 2024
Reference Tensor<T>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the Python Buffer protocol as a type and exposes the data for most unmanaged types as either a scalar
Span<>or 2D arraySpan2D.There is also an optional ReadOnlySpan interface.
This is a significant feature for numpy so that users dont need to convert ndarrays back into lists and then CSnakes marshals them.
It also works for
bytes(asReadOnlySpan<byte>) andbytearrayas (Span<byte>).It also opens up a bidirectional interface for exchanging low-level data via the span.