Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical position change between 1.207 and 2 #833

Open
scolby33 opened this issue Sep 10, 2019 · 13 comments
Open

Vertical position change between 1.207 and 2 #833

scolby33 opened this issue Sep 10, 2019 · 13 comments

Comments

@scolby33
Copy link

scolby33 commented Sep 10, 2019

Using Kitty and Tmux on macOS with FiraCode 1.207:
Screen Shot 2019-09-10 at 10 59 53

Same configuration but with FiraCode 2:
Screen Shot 2019-09-10 at 10 56 15

The text is no longer vertically centered in the colored background cell.

Additionally, I noticed that for both versions, the text on the background is not vertically aligned with text on the default background.
With 1.207:
Screen Shot 2019-09-10 at 11 03 38

With 2:
Screen Shot 2019-09-10 at 10 56 41

It's worse with the new version and I had never noticed the discrepancy before with the old version but this may be the same issue.

I am happy to provide further information about my configuration. Please let me know what information would be useful.

EDIT: I tried the same experiment in Terminal.app, which is using the default "Pro" theme except for the font changed to Fira Code Regular 14pt.
With 1.207:
Screen Shot 2019-09-10 at 11 14 52

With 2:
Screen Shot 2019-09-10 at 11 14 23

In this case, with the new version, the text is too low. 😞

@tonsky
Copy link
Owner

tonsky commented Sep 11, 2019

It’s a shame, but I have very little control over how terminals determine where the line starts and ends. As you can see, with the same fonts two different terminals make completely different decision. The fact that 1.207 worked fine in your two cases was a happy coincidence. Many people were struggling with it #798. I’d like to please everyone but I just don’t know how and if it’s possible at all

@caze73
Copy link

caze73 commented Sep 12, 2019

I've watched a similar behaviour in IntelliJ 2019.2. There is a more space between the characters.

With 1.207:
FiraCode_1 207

With 2:
FiraCode_2

@mpolden
Copy link

mpolden commented Sep 17, 2019

I've watched a similar behaviour in IntelliJ 2019.2. There is a more space between the characters.

With 1.207:
FiraCode_1 207

With 2:
FiraCode_2

I have this problem too. Happens across all applications where I use this font, Emacs, IntelliJ and iTerm. Considering downgrading as v2 just looks plain strange at 14pt, with the added horizontal spacing.

@tonsky
Copy link
Owner

tonsky commented Sep 18, 2019

Actually 1.207 was the version that (unintentionally) introduced the biggest change in line height. 2 is most close (not exact, but almost the same) to 1.206 and everything that came before it (including Fira Mono)

@scolby33
Copy link
Author

It looks like the answer is this is a wont/cantfix at the moment. Am I correct in that understanding?

It is strange to me how different FiraCode seems to behave compared to the other mono fonts on my system but it's true that they don't update with any frequency and they're probably not using even half as many fancy font features as FiraCode does.

Perhaps I should ask the developers of other programs for font tuning options haha...

@deae
Copy link

deae commented Sep 20, 2019

I find the 2.0 ttf version, the different font weight has different spacing(the regular is normal, the medium has big spacing).
The spacing should being the same.

@tonsky
Copy link
Owner

tonsky commented Sep 23, 2019

I’d happy to fix but not sure what to do. Rolling back to 1.207 is not an option, as it caused many complaints as well

@minusf
Copy link

minusf commented Sep 30, 2019

this issue is present in terminal.app as well, however the vertical space is at the top of the line, not the bottom as in kitty (i am also a kitty user). iTerm does not manifest this issue for some reason. this is quite a showstopper for me unfortunately and rolling back.

@nathanielevan
Copy link

nathanielevan commented Jan 24, 2023

Sorry for bumping this up again, but I just found myself facing this same issue; any chance of this being resolved? I understand 1.207 breaking for a lot of people, but maybe reverting to 1.206 metrics would work? Version 1.207 looks closer to me to version 1.206 than version 2 does, while for other people version 2 looks closer to v1.206 than 1.207 does; maybe 1.206 metrics is the sweet spot after all?

In any case, many thanks for your work on Fira Code. Big fan, it's in my rotation of fonts

@tonsky
Copy link
Owner

tonsky commented Jan 24, 2023

There will most likely be another change in metrics for v7 to satisfy Google Fonts. I’ll do my best to try to make everyone happy

@nathanielevan
Copy link

No pressure at all mate, in any case using version 1.206 works for me either way. Don't wanna feel like I'm demanding something -- just asking if it's on the plans. But just pitching in that if 1.207 caused problems for a lot of people, 1.206 might be a point of reference

@scolby33
Copy link
Author

scolby33 commented Feb 2, 2023

Is there a good way to determine what version I have installed on my system? I've completely forgotten how I solved this, but it wasn't "stick with 1.207 for all time," since the checksums of what I have installed and the 1.207 release are not the same.

@nathanielevan
Copy link

Is there a good way to determine what version I have installed on my system?

If you use Linux, I use FontForge to inspect the font. Look into "Element" --> "Font Info" and you'll see this information:
scshot-030223-054230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants