Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.. and ..= are looking very different #757

Closed
upsuper opened this issue May 9, 2019 · 8 comments
Closed

.. and ..= are looking very different #757

upsuper opened this issue May 9, 2019 · 8 comments
Labels
Milestone

Comments

@upsuper
Copy link

upsuper commented May 9, 2019

It seems that currently the ligature for .. and ..= are looking very different (the dots of the latter are much bigger and in the middle vertically). Is there any reason ..= is designed that way?

This ligature looks unfortunate for Rust, because in Rust .. is exclusive range, and ..= is inclusive range, they have very similar semantics.

It would be great if ..= can look similar to ...

@tonsky
Copy link
Owner

tonsky commented May 9, 2019

I don’t remember where it comes from but I believe it is an operator in some language. I agree that maybe rendering it that way was not the greatest idea, along with .= and .-

@tonsky tonsky added the conflict label May 9, 2019
@upsuper
Copy link
Author

upsuper commented May 9, 2019

It might be a good idea to have a table to record where each combination is from, and what conflicting cases are. That would probably be helpful when this kind of issues are raised.

If you can dump a list of current ligatures in a wiki page with some examples, people may start filling it with usecases I believe, maybe something like:

  • =<
  • ..=
    • (unknown)
    • range inclusive: Rust

@tonsky
Copy link
Owner

tonsky commented May 11, 2019

@upsuper
Copy link
Author

upsuper commented May 11, 2019

Hmmm... So it was added for Rust, but it doesn't work well in Rust... That's interesting :D

@tonsky
Copy link
Owner

tonsky commented May 11, 2019

I can see why it doesn’t work well now though. I’ll see what I can do.

@upsuper
Copy link
Author

upsuper commented May 11, 2019

Thanks!

@upsuper
Copy link
Author

upsuper commented Aug 8, 2019

Ping on this. So actually given the spreadsheets, there isn't really a conflict. The ligature doesn't work well in the language it meant to benefit. Could you probably remove such ligature or make it align with ..?

@tonsky
Copy link
Owner

tonsky commented Aug 8, 2019

Yes I’ll remove it

@tonsky tonsky added this to the 1.208 milestone Aug 27, 2019
@tonsky tonsky closed this as completed in 23a64c2 Sep 2, 2019
tonsky added a commit that referenced this issue Sep 2, 2019
@tonsky tonsky mentioned this issue Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants