Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add #!/, (), and }) ligs #169

Closed
easyaspi314 opened this issue Apr 12, 2016 · 7 comments
Closed

Please add #!/, (), and }) ligs #169

easyaspi314 opened this issue Apr 12, 2016 · 7 comments

Comments

@easyaspi314
Copy link

#!/ is used in shell scripts, like:

#!/system/bin/sh
echo "Hello, world!"

() and )} is used in many languages as well, such as after a Java interface override. Both are used commonly, especially (). This one should be a given, especially since we have a box for [].

myButton.setOnClickListener(new View.OnClickListener() {
    @Override
    public void onClick(View v) {
        FragmentManager manager = getActivity().getFragmentManager();
        FragmentTransaction transaction = manager.beginTransaction();
        MyFragment myFragment = MyFragment.newInstance();
        myFragment.setArguments(getActivity().getIntent().getExtras());
        transaction = transaction.replace(android.R.id.content, myFragment);
        transaction.commit();
    }
});

In Fira Code:
screen shot 2016-04-12 at 6 40 52 pm

@easyaspi314
Copy link
Author

@tonsky how about this for an idea?

double parenthesis

@tonsky
Copy link
Owner

tonsky commented Apr 13, 2016

@easyaspi314 Not sure about that. Don’t like uneven spacing, and you would never guess all the contexts where this combination might pop up

@easyaspi314
Copy link
Author

Well what about the ); ?
On Apr 13, 2016 11:38 AM, "Nikita Prokopov" notifications@github.com
wrote:

@easyaspi314 https://github.com/easyaspi314 Not sure about that. Don’t
like uneven spacing, and you would never guess all the contexts where this
combination might pop up


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#169 (comment)

@tonsky
Copy link
Owner

tonsky commented Apr 13, 2016

I can tune the spacing, but I don’t see it as an improvement. You see, idea
of Fira Code was to make sequences that are one logical operator look like
one symbol. In this case, semicolon and closing paren are not part of the
same sequence. In fact, they’re part of different constructs. I don’t think
I should move them closer together.

On Wed, Apr 13, 2016 at 9:40 PM easyaspi314 (Devin) <
notifications@github.com> wrote:

Well what about the ); ?
On Apr 13, 2016 11:38 AM, "Nikita Prokopov" notifications@github.com
wrote:

@easyaspi314 https://github.com/easyaspi314 Not sure about that. Don’t
like uneven spacing, and you would never guess all the contexts where
this
combination might pop up


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#169 (comment)


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#169 (comment)

@easyaspi314
Copy link
Author

OK. Do you think you can do anything with #! and #!/?

@tonsky
Copy link
Owner

tonsky commented Apr 13, 2016

#! makes sense, yes. But slash in #!/ is, again, not part of that logical
sequence

On Wed, Apr 13, 2016, 22:12 easyaspi314 (Devin) notifications@github.com
wrote:

OK. Do you think you can do anything with #! and #!/?


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#169 (comment)

@easyaspi314
Copy link
Author

OK.

@tonsky tonsky closed this as completed in 032314d Nov 5, 2016
Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this issue Mar 12, 2020
Update Puma dependency to ~> 3.10

Tried to install Puma on freshly installed Arch Linux instance failed since older version of Puma doesn't support latest OpenSSL version([related issue](puma/puma#1380)).

This PR updates Puma dependency to the latest available version, 3.10. Newer version of Puma introduced some changes to Puma::CLI interface, so I also updated integration test to reflect it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants