ci: update github actions to latest stable #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
|
Why draft? |
Provenance is now generated by default with bake action v4: https://github.com/tonistiigi/xx/actions/runs/7473571579/job/20337993559#step:6:15 Needs to handle this correctly first (align filename or just disable it). |
ae5fe7e to
2bea628
Compare
This comment was marked as outdated.
This comment was marked as outdated.
tonistiigi
reviewed
Jan 13, 2024
| cd "$pdir" | ||
| binname=$(find . -name '*.tar.gz') | ||
| filename=$(basename "${binname%.tar.gz}") | ||
| mv "provenance.json" "${filename}.provenance.json" |
There was a problem hiding this comment.
Can't we set the provenance filename with build request instead of renaming later?
There was a problem hiding this comment.
It works with 5433bff but filenames are not aligned so needs to rename them anyway 😣: https://github.com/tonistiigi/xx/actions/runs/7783168263/job/21221059915?pr=141#step:7:7
I revert this change, I think my initial attempt looks better: #141 (comment)
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
5433bff to
f5dc0bd
Compare
tonistiigi
approved these changes
Feb 5, 2024
This was referenced Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds dependabot to keep gha up to date