Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove dependency to urllib3 from kube_config, pin urlllib>=1.23 due to CVE-2018-20060 #56

Merged
merged 2 commits into from
Dec 16, 2018

Conversation

tomplus
Copy link
Owner

@tomplus tomplus commented Dec 13, 2018

This library doesn't need to use the urllib3 - it uses the iohttp instead. In this PR I remove a dependency to urllib3 from kube_config.py. The library is still required by the generated part by swagger-codegen.

I also change the required version >=1.23 due to security patches.

@codecov-io
Copy link

codecov-io commented Dec 13, 2018

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   94.38%   94.38%           
=======================================
  Files          20       20           
  Lines        1354     1354           
=======================================
  Hits         1278     1278           
  Misses         76       76
Impacted Files Coverage Δ
kubernetes_asyncio/config/kube_config.py 92.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d23670b...bd19590. Read the comment docs.

@tomplus tomplus merged commit ab8eac4 into master Dec 16, 2018
@TrueBrain
Copy link

Any chance for a new release soon? The GitHub banner is pretty invasive (for good reasons I guess), and it would be nice to get ride of it :)

Tnx a lot, also for this library :)

@tomplus
Copy link
Owner Author

tomplus commented Dec 30, 2018

@TrueBrain Sure, I've just released the version v8.0.2. Thank you.

@tomplus tomplus deleted the feat/upgrade-urllib3 branch January 11, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants